Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inverted-colors variant #11693

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Add inverted-colors variant #11693

merged 2 commits into from
Feb 21, 2025

Conversation

lukewarlow
Copy link
Contributor

Add a variant for the inverted-colors media query.

This has been supported in Safari for a while. I'm also implementing support in Chrome atm.

I've decided to only add the inverted-colors: inverted variant because the none state isn't really useful.

@lukewarlow lukewarlow mentioned this pull request Jul 26, 2023
Merged
@lukewarlow lukewarlow mentioned this pull request Sep 8, 2023
Closed
@RobinMalfait RobinMalfait changed the base branch from master to archive/master-2024-02-23 March 4, 2024 21:43
@RobinMalfait RobinMalfait changed the base branch from archive/master-2024-02-23 to next April 17, 2024 21:00
@RobinMalfait RobinMalfait changed the title Add inverted-colors variant Add inverted-colors variant Apr 17, 2024
@RobinMalfait
Copy link
Member

Hey!

You might have noticed that I forced pushed to this branch. The reason is because the PR now uses next as the base branch which is our working branch for Tailwind CSS v4. In other words, the feature you implemented here is now written in the new codebase.

The code is ported as-is, so no API changes of your feature happened while moving it to the new codebase.

I also made sure to add you as a co-author because you still deserve all the credit 💪

@RobinMalfait RobinMalfait requested a review from a team as a code owner November 21, 2024 13:40
@lukewarlow lukewarlow force-pushed the inverted-colors branch 2 times, most recently from bda1052 to 6d74187 Compare January 23, 2025 14:04
philipp-spiess
philipp-spiess approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We're landing this in main behind a feature flag and plan to release this with 4.1 later 👍

@philipp-spiess philipp-spiess merged commit 751eb74 into tailwindlabs:main Feb 21, 2025
5 checks passed
@dcastil dcastil mentioned this pull request Apr 5, 2025
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

Assignees
No one assigned
Labels
v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukewarlow @RobinMalfait @philipp-spiess